fix: auto-fix code issues (cron)
- 修复重复导入/字段 - 修复异常处理 - 修复PEP8格式问题 - 添加类型注解
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# InsightFlow 代码审查报告
|
||||
|
||||
扫描时间: Sat Feb 28 03:03:08 AM CST 2026
|
||||
扫描时间: Sat Feb 28 03:03:50 AM CST 2026
|
||||
扫描文件数: 40
|
||||
|
||||
## 扫描的文件列表
|
||||
@@ -50,9 +50,9 @@
|
||||
|
||||
- 🔴 Critical: 8
|
||||
- 🟠 Error: 0
|
||||
- 🟡 Warning: 31
|
||||
- 🔵 Info: 3349
|
||||
- **总计: 3388**
|
||||
- 🟡 Warning: 29
|
||||
- 🔵 Info: 2267
|
||||
- **总计: 2304**
|
||||
|
||||
## ✅ 已自动修复的问题
|
||||
|
||||
@@ -60,92 +60,88 @@
|
||||
|
||||
## ⚠️ 需要人工确认的问题
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:245` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:211` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:608` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:244` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:210` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:580` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:339` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/developer_ecosystem_manager.py:496` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/security_manager.py:58` [critical] 硬编码密钥,应使用环境变量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:1435` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/plugin_manager.py:238` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/developer_ecosystem_manager.py:477` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/security_manager.py:56` [critical] 硬编码密钥,应使用环境变量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:1420` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/plugin_manager.py:229` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_multimodal.py:136` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_phase8_task6.py:531` [critical] 硬编码 API Key,应使用环境变量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/search_manager.py:2097` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_phase8_task6.py:530` [critical] 硬编码 API Key,应使用环境变量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/search_manager.py:2079` [critical] 潜在的 SQL 注入风险,使用参数化查询
|
||||
|
||||
## 📋 其他发现的问题
|
||||
|
||||
### duplicate_import
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:73` - 重复导入: from alibabacloud_tea_openapi import models as open_api_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:74` - 重复导入: from alibabacloud_tingwu20230930 import models as tingwu_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:75` - 重复导入: from alibabacloud_tingwu20230930.client import Client as TingwuSDKClient
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:1177` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/knowledge_reasoner.py:122` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ai_manager.py:446` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/llm_client.py:126` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/export_manager.py:282` - 重复导入: import csv
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_phase8_task8.py:325` - 重复导入: import random
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:72` - 重复导入: from alibabacloud_tea_openapi import models as open_api_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:73` - 重复导入: from alibabacloud_tingwu20230930 import models as tingwu_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:74` - 重复导入: from alibabacloud_tingwu20230930.client import Client as TingwuSDKClient
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:1113` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/knowledge_reasoner.py:118` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ai_manager.py:433` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/llm_client.py:122` - 重复导入: import re
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/export_manager.py:278` - 重复导入: import csv
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_phase8_task8.py:324` - 重复导入: import random
|
||||
|
||||
### extra_blank_line
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:14` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:28` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:408` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:445` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:488` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:11` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:24` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:315` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:340` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/test_phase8_task5.py:35` - 多余的空行
|
||||
- ... 还有 1081 个类似问题
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:13` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:27` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:430` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:467` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:510` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:10` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:23` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:314` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:339` - 多余的空行
|
||||
|
||||
### line_too_long
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:960` - 行长度 147 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/db_manager.py:168` - 行长度 125 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/db_manager.py:704` - 行长度 129 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:4571` - 行长度 130 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/developer_ecosystem_manager.py:963` - 行长度 122 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/llm_client.py:109` - 行长度 131 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:783` - 行长度 121 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:785` - 行长度 122 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:897` - 行长度 121 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:975` - 行长度 121 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:932` - 行长度 147 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/db_manager.py:161` - 行长度 125 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/db_manager.py:697` - 行长度 129 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:4385` - 行长度 130 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/developer_ecosystem_manager.py:944` - 行长度 122 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/llm_client.py:105` - 行长度 131 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:768` - 行长度 121 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:770` - 行长度 122 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:882` - 行长度 121 超过 120 字符
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/localization_manager.py:960` - 行长度 121 超过 120 字符
|
||||
- ... 还有 4 个类似问题
|
||||
|
||||
### magic_number
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:50` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:94` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:114` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:116` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:126` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:299` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:315` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:400` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:402` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:403` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:49` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:93` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:113` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:115` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:125` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:303` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:337` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:422` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:424` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:425` - 魔法数字 10,建议提取为常量
|
||||
- ... 还有 2178 个类似问题
|
||||
|
||||
### missing_type_annotation
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2736` - 函数 '_row_to_alert_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2758` - 函数 '_row_to_alert_channel' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2774` - 函数 '_row_to_alert' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2796` - 函数 '_row_to_suppression_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2808` - 函数 '_row_to_resource_metric' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2821` - 函数 '_row_to_capacity_plan' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2835` - 函数 '_row_to_auto_scaling_policy' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2854` - 函数 '_row_to_scaling_event' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2870` - 函数 '_row_to_health_check' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2889` - 函数 '_row_to_health_check_result' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2708` - 函数 '_row_to_alert_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2730` - 函数 '_row_to_alert_channel' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2746` - 函数 '_row_to_alert' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2768` - 函数 '_row_to_suppression_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2780` - 函数 '_row_to_resource_metric' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2793` - 函数 '_row_to_capacity_plan' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2807` - 函数 '_row_to_auto_scaling_policy' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2826` - 函数 '_row_to_scaling_event' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2842` - 函数 '_row_to_health_check' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2861` - 函数 '_row_to_health_check_result' 的参数 'row' 缺少类型注解
|
||||
- ... 还有 60 个类似问题
|
||||
|
||||
### unused_import
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:10` - 未使用的导入: sys
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:12` - 未使用的导入: Any
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:9` - 未使用的导入: Any
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:11` - 未使用的导入: Any
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/workflow_manager.py:16` - 未使用的导入: urllib.request
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/plugin_manager.py:14` - 未使用的导入: urllib.request
|
||||
|
||||
Reference in New Issue
Block a user