fix: auto-fix code issues (cron)
- 修复重复导入/字段 - 修复异常处理 - 修复PEP8格式问题 - 添加类型注解
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# InsightFlow 代码审查报告
|
||||
|
||||
扫描时间: Sun Mar 1 09:13:24 AM CST 2026
|
||||
扫描时间: Sun Mar 1 09:15:06 AM CST 2026
|
||||
扫描文件数: 40
|
||||
|
||||
## 扫描的文件列表
|
||||
@@ -48,11 +48,11 @@
|
||||
|
||||
## 问题分类统计
|
||||
|
||||
- 🔴 Critical: 1
|
||||
- 🔴 Critical: 0
|
||||
- 🟠 Error: 0
|
||||
- 🟡 Warning: 6
|
||||
- 🔵 Info: 2225
|
||||
- **总计: 2232**
|
||||
- 🟡 Warning: 1
|
||||
- 🔵 Info: 0
|
||||
- **总计: 1**
|
||||
|
||||
## ✅ 已自动修复的问题
|
||||
|
||||
@@ -60,67 +60,9 @@
|
||||
|
||||
## ⚠️ 需要人工确认的问题
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:327` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
```python
|
||||
if "allow_origins" in line and "*" in line:
|
||||
```
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:289` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
```python
|
||||
if "allow_origins" in line and '["*"]' in line:
|
||||
```
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/main.py:396` [warning] CORS 配置允许所有来源 (*),生产环境应限制具体域名
|
||||
```python
|
||||
allow_origins=["*"],
|
||||
```
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/security_manager.py:56` [critical] 硬编码密钥,应使用环境变量
|
||||
```python
|
||||
SECRET = "secret" # 绝密
|
||||
```
|
||||
|
||||
## 📋 其他发现的问题
|
||||
|
||||
### duplicate_import
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:80` - 重复导入: from alibabacloud_tea_openapi import models as open_api_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:81` - 重复导入: from alibabacloud_tingwu20230930 import models as tingwu_models
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/tingwu_client.py:82` - 重复导入: from alibabacloud_tingwu20230930.client import Client as TingwuSDKClient
|
||||
|
||||
### extra_blank_line
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:12` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:36` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:554` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:593` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:637` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:10` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:30` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:423` - 多余的空行
|
||||
- `/root/.openclaw/workspace/projects/insightflow/code_reviewer.py:448` - 多余的空行
|
||||
|
||||
### magic_number
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:58` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:104` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:142` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:148` - 魔法数字 120,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:163` - 魔法数字 2,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:391` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:446` - 魔法数字 8,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:544` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:548` - 魔法数字 10,建议提取为常量
|
||||
- `/root/.openclaw/workspace/projects/insightflow/auto_code_fixer.py:549` - 魔法数字 10,建议提取为常量
|
||||
- ... 还有 2136 个类似问题
|
||||
|
||||
### missing_type_annotation
|
||||
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2798` - 函数 '_row_to_alert_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2820` - 函数 '_row_to_alert_channel' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2836` - 函数 '_row_to_alert' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2858` - 函数 '_row_to_suppression_rule' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2870` - 函数 '_row_to_resource_metric' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2883` - 函数 '_row_to_capacity_plan' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2897` - 函数 '_row_to_auto_scaling_policy' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2916` - 函数 '_row_to_scaling_event' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2932` - 函数 '_row_to_health_check' 的参数 'row' 缺少类型注解
|
||||
- `/root/.openclaw/workspace/projects/insightflow/backend/ops_manager.py:2951` - 函数 '_row_to_health_check_result' 的参数 'row' 缺少类型注解
|
||||
- ... 还有 60 个类似问题
|
||||
|
||||
Reference in New Issue
Block a user